carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sraghunandan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Date Wed, 13 Sep 2017 08:44:29 GMT
Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r138555709
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/partition/PartitionUtil.java
---
    @@ -71,6 +72,10 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
             default:
               return data;
           }
    +    } catch (NumberFormatException ex) {
    +      return new IllegalArgumentException(ex.getMessage());
    --- End diff --
    
    can throw MalformedCarbonException instead of runtime.
    Its not good coding practice to return the exception object instead of throwing it


---

Mime
View raw message