carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1273: [CARBONDATA-1400] Fix bug of array column out...
Date Wed, 13 Sep 2017 03:52:59 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138518998
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
    @@ -79,29 +82,29 @@ public void setDoublePage(double[] doubleData) {
       /**
        * Create a new column page for decimal page
        */
    -  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes, int scale, int precision)
    -      throws MemoryException {
    +  static ColumnPage newDecimalColumnPage(TableSpec.ColumnSpec columnSpec, byte[] lvEncodedBytes,
    +      int scale, int precision) throws MemoryException {
    --- End diff --
    
    I will try, but it is a temporary solution. 
    I think the correct way is to make DataType a class instead of enum, and keep precision
and scale in that.


---

Mime
View raw message