carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Date Wed, 13 Sep 2017 02:54:59 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1345#discussion_r138514170
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java
---
    @@ -211,24 +199,23 @@ public long decodeLong(int value) {
           throw new RuntimeException("internal error: " + debugInfo());
         }
     
    -    @Override
    -    public double decodeDouble(byte value) {
    -      return BigDecimal.valueOf(value).divide(factor).doubleValue();
    +    @Override public double decodeDouble(byte value) {
    --- End diff --
    
    move @Override to previous line


---

Mime
View raw message