carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Date Wed, 13 Sep 2017 02:53:04 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1345#discussion_r138514001
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java
---
    @@ -98,12 +97,11 @@ protected ColumnPageEncoderMeta getEncoderMeta(ColumnPage inputPage)
{
       public ColumnPageDecoder createDecoder(ColumnPageEncoderMeta meta) {
         assert meta instanceof AdaptiveFloatingEncoderMeta;
         AdaptiveFloatingEncoderMeta codecMeta = (AdaptiveFloatingEncoderMeta) meta;
    -    final Compressor compressor = CompressorFactory.getInstance().getCompressor(
    -        codecMeta.getCompressorName());
    +    final Compressor compressor =
    +        CompressorFactory.getInstance().getCompressor(codecMeta.getCompressorName());
         final DataType targetDataType = codecMeta.getTargetDataType();
         return new ColumnPageDecoder() {
    -      @Override
    -      public ColumnPage decode(byte[] input, int offset, int length)
    +      @Override public ColumnPage decode(byte[] input, int offset, int length)
    --- End diff --
    
    move `@Override` to previous line


---

Mime
View raw message