carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1346: [CARBONDATA-1472] Optimize memory and fix nos...
Date Tue, 12 Sep 2017 12:50:54 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1346#discussion_r138254137
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanEqualFilterExecuterImpl.java
---
    @@ -265,11 +265,15 @@ private BitSet getFilteredIndexes(DimensionColumnDataChunk dimensionColumnDataCh
           DirectDictionaryGenerator directDictionaryGenerator = DirectDictionaryKeyGeneratorFactory
    --- End diff --
    
    Now as we are not adding one in default value, while searching for last index of null
value in binary search, we need to add +1 in search result as search will be last index of
null value inclusive


---

Mime
View raw message