carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1346: [CARBONDATA-1472] Optimize memory and fix nos...
Date Tue, 12 Sep 2017 12:50:29 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1346#discussion_r138253487
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeAbstractDimensionDataChunkStore.java
---
    @@ -68,10 +72,9 @@
        * @param numberOfRows   total number of rows
        */
       public UnsafeAbstractDimensionDataChunkStore(long totalSize, boolean isInvertedIdex,
    -      int numberOfRows) {
    +      int numberOfRows) throws MemoryException {
         // allocating the data page
    -    this.dataPageMemoryBlock =
    -        MemoryAllocatorFactory.INSATANCE.getMemoryAllocator().allocate(totalSize);
    +    this.dataPageMemoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(taskId, totalSize);
    --- End diff --
    
    From this class it self we can throw runtime exception if Unsafesafe memory manager not
able to allocate requested memory


---

Mime
View raw message