carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1273: [CARBONDATA-1400] Fix bug of array column out...
Date Tue, 12 Sep 2017 06:33:46 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138262250
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java
---
    @@ -67,6 +70,17 @@ public void setByteArrayPage(byte[][] byteArray) {
       }
     
       @Override
    +  public byte[] getLVFlattenedBytePage() throws IOException {
    +    ByteArrayOutputStream stream = new ByteArrayOutputStream();
    +    DataOutputStream out = new DataOutputStream(stream);
    +    for (byte[] byteArrayDatum : byteArrayData) {
    +      out.writeInt(byteArrayDatum.length);
    --- End diff --
    
    can' t we use short here?


---

Mime
View raw message