carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio...
Date Fri, 08 Sep 2017 14:37:57 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1265#discussion_r137806977
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/EqualToFilterImpl.java
---
    @@ -50,7 +50,7 @@ public EqualToFilterImpl(EqualToExpression equalTo, PartitionInfo partitionInfo)
               literal.getLiteralExpValue().toString(),
               partitionInfo.getColumnSchemaList().get(0).getDataType());
           if (PartitionType.RANGE == partitionInfo.getPartitionType() && value instanceof
String) {
    -        value = ByteUtil.toBytes((String)value);
    +        value = ByteUtil.toBytesForPlainValue((String)value);
    --- End diff --
    
    `ByteUtil.toBytes` will do `val = val ^ Integer.MIN_VALUE;` 
    So I think it can not be used as normal utility function to convert int to byte[4]


---

Mime
View raw message