carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio...
Date Fri, 08 Sep 2017 14:31:14 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1265#discussion_r137805419
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
    @@ -366,7 +364,7 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
         BitSet bitSet = new BitSet(numerOfRows);
         byte[][] filterValues = this.filterRangeValues;
         // binary search can only be applied if column is sorted
    -    if (isNaturalSorted) {
    +    if (isNaturalSorted && !dimensionColumnDataChunk.isNoDicitionaryColumn())
{
    --- End diff --
    
    In this PR, plain value (no dictionary) is using adaptive encoding, it is not sorted.
I think it will make store size smaller but for some filter query it will be slower. Any suggestion?


---

Mime
View raw message