carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhatchayani <...@git.apache.org>
Subject [GitHub] carbondata pull request #1334: [CARBONDATA-1451] Removing configuration for ...
Date Thu, 07 Sep 2017 05:42:24 GMT
Github user dhatchayani commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1334#discussion_r137450091
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonV3DataFormatConstants.java
---
    @@ -61,24 +61,8 @@
       short NUMBER_OF_COLUMN_TO_READ_IN_IO_MIN = 1;
     
       /**
    -   * number of rows per blocklet column page
    -   */
    -  @CarbonProperty
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE = "number.of.rows.per.blocklet.column.page";
    -
    -  /**
        * number of rows per blocklet column page default value
        */
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = "32000";
    -
    -  /**
    -   * number of rows per blocklet column page max value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MAX = 32000;
    -
    -  /**
    -   * number of rows per blocklet column page min value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MIN = 8000;
    +  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = 32000;
    --- End diff --
    
    this is not configurable. 32000 is the default constant stored as "NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT"


---

Mime
View raw message