carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio...
Date Thu, 07 Sep 2017 05:40:44 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1265#discussion_r137449915
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanEqualFilterExecuterImpl.java
---
    @@ -262,10 +259,7 @@ private BitSet getFilteredIndexes(DimensionColumnDataChunk dimensionColumnDataCh
           int numerOfRows) {
         byte[] defaultValue = null;
         if (dimColEvaluatorInfoList.get(0).getDimension().hasEncoding(Encoding.DIRECT_DICTIONARY))
{
    -      DirectDictionaryGenerator directDictionaryGenerator = DirectDictionaryKeyGeneratorFactory
    -          .getDirectDictionaryGenerator(
    -              dimColEvaluatorInfoList.get(0).getDimension().getDataType());
    -      int key = directDictionaryGenerator.generateDirectSurrogateKey(null) + 1;
    +      int key = 0;
    --- End diff --
    
    I think it is better to get null key from respective interfaces instead of hard code.
if the null value key changes in future also no effect here


---

Mime
View raw message