carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1297: [CARBONDATA-1429] Add a value based compressi...
Date Wed, 06 Sep 2017 13:42:39 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1297#discussion_r137270300
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingStrategy.java
---
    @@ -104,18 +107,31 @@ private ColumnPageEncoder createEncoderForMeasure(ColumnPage columnPage)
{
           case SHORT:
           case INT:
           case LONG:
    -        return selectCodecByAlgorithmForIntegral(stats).createEncoder(null);
    +        return selectCodecByAlgorithmForIntegral(stats,
    +            DecimalConverterFactory.DecimalConverterType.DECIMAL_LONG).createEncoder(null);
    +      case DECIMAL:
    +        return createEncoderForDecimalDataTypeMeasure(columnPage);
    --- End diff --
    
    Rename as others, `selectCodecByAlgorithmForDecimal`. 


---

Mime
View raw message