Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1302-carbondata@git.apache.org>
In-Reply-To: <git-pr-1302-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1302: [CARBONDATA-1435] Fix reader backward compati...
Content-Type: text/plain
Message-Id: <20170831060456.89045F5538@git1-us-west.apache.org>
Date: Thu, 31 Aug 2017 06:04:56 +0000 (UTC)
archived-at: Thu, 31 Aug 2017 06:04:58 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1302#discussion_r136251781
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingStrategy.java ---
    @@ -112,10 +112,41 @@ public ColumnPageDecoder createDecoderLegacy(ValueEncoderMeta metadata) {
           case SHORT:
           case INT:
           case LONG:
    -        return DefaultEncodingStrategy.selectCodecByAlgorithmForIntegral(stats).createDecoder(null);
    +        // create the codec based on algorithm and create decoder by recovering the metadata
    +        ColumnPageCodec codec = DefaultEncodingStrategy.selectCodecByAlgorithmForIntegral(stats);
    +        if (codec instanceof AdaptiveIntegralCodec) {
    +          AdaptiveIntegralCodec adaptiveCodec = (AdaptiveIntegralCodec) codec;
    +          AdaptiveIntegralEncoderMeta meta = new AdaptiveIntegralEncoderMeta(
    --- End diff --
    
    It is  because AdaptiveIntegralEncoderMeta constructor is different from other. I will modify this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---