Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenliang613 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1257-carbondata@git.apache.org>
In-Reply-To: <git-pr-1257-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Content-Type: text/plain
Message-Id: <20170823084948.F1BB8E088D@git1-us-west.apache.org>
Date: Wed, 23 Aug 2017 08:49:48 +0000 (UTC)
archived-at: Wed, 23 Aug 2017 08:49:50 -0000

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1257#discussion_r134692412
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java ---
    @@ -73,27 +60,23 @@ public CarbondataRecordSetProvider(CarbondataConnectorId connectorId, CarbonTabl
     
         CarbondataSplit carbondataSplit =
             checkType(split, CarbondataSplit.class, "split is not class CarbondataSplit");
    -    checkArgument(carbondataSplit.getConnectorId().equals(connectorId), "split is not for this connector");
    +    checkArgument(carbondataSplit.getConnectorId().equals(connectorId),
    +        "split is not for this connector");
     
    -    StringBuffer targetColsBuffer = new StringBuffer();
         String targetCols = "";
         // Convert all columns handles
         ImmutableList.Builder<CarbondataColumnHandle> handles = ImmutableList.builder();
         for (ColumnHandle handle : columns) {
           handles.add(checkType(handle, CarbondataColumnHandle.class, "handle"));
    -      targetColsBuffer.append(((CarbondataColumnHandle) handle).getColumnName()).append(",");
    +      targetCols += ((CarbondataColumnHandle) handle).getColumnName() + ",";
    --- End diff --
    
    i didn't see any code to resolve this comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---