Return-Path: <issues-return-16846-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 306B6200CF2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat, 19 Aug 2017 06:48:19 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 2EC4816B965; Sat, 19 Aug 2017 04:48:19 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 6B6D816B951
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 19 Aug 2017 06:48:18 +0200 (CEST)
Received: (qmail 91027 invoked by uid 500); 19 Aug 2017 04:48:17 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 91018 invoked by uid 99); 19 Aug 2017 04:48:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Aug 2017 04:48:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 7514BDFDDD; Sat, 19 Aug 2017 04:48:16 +0000 (UTC)
From: xuchuanyin <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1267-carbondata@git.apache.org>
In-Reply-To: <git-pr-1267-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1267: [CARBONDATA-1326] Findbug fixes
Content-Type: text/plain
Message-Id: <20170819044816.7514BDFDDD@git1-us-west.apache.org>
Date: Sat, 19 Aug 2017 04:48:16 +0000 (UTC)
archived-at: Sat, 19 Aug 2017 04:48:19 -0000

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1267#discussion_r134082911
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonDeleteFilesDataReader.java ---
    @@ -216,6 +198,17 @@ public DeleteDeltaBlockDetails getCompactedDeleteDeltaFileFromBlock(List<String>
         }
         return deleteDeltaResultSet;
       }
    +  static class DeleteDeltaFileReaderCallable implements Callable<DeleteDeltaBlockDetails> {
    --- End diff --
    
    Why use `static` class ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---