Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1259-carbondata@git.apache.org>
In-Reply-To: <git-pr-1259-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1259: [Review][CARBONDATA-1381] Add test cases for ...
Content-Type: text/plain
Message-Id: <20170817091504.8FC09DFA43@git1-us-west.apache.org>
Date: Thu, 17 Aug 2017 09:15:04 +0000 (UTC)
archived-at: Thu, 17 Aug 2017 09:15:06 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1259#discussion_r133662025
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/BucketingInfo.java ---
    @@ -44,4 +51,21 @@ public int getNumberOfBuckets() {
         return numberOfBuckets;
       }
     
    +  @Override public void write(DataOutput out) throws IOException {
    +    out.writeInt(numberOfBuckets);
    +    out.writeInt(listOfColumns.size());
    +    for (ColumnSchema aColSchema : listOfColumns) {
    +      aColSchema.write(out);
    +    }
    +  }
    +
    +  @Override public void readFields(DataInput in) throws IOException {
    +    this.numberOfBuckets = in.readInt();
    +    int colSchemaSize = in.readInt();
    +    listOfColumns = new ArrayList<>(colSchemaSize);
    +    for (int i = 0; i < colSchemaSize; i++) {
    +      ColumnSchema aSchema = new ColumnSchema();
    +      aSchema.readFields(in);
    --- End diff --
    
    need to add it in `listOfColumns`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---