Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: xuchuanyin <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1213-carbondata@git.apache.org>
In-Reply-To: <git-pr-1213-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1213: [CARBONDATA-1342] Fixed bugs for spark conf p...
Content-Type: text/plain
Message-Id: <20170805033944.90CE9F3246@git1-us-west.apache.org>
Date: Sat,  5 Aug 2017 03:39:43 +0000 (UTC)
archived-at: Sat, 05 Aug 2017 03:39:47 -0000

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1213#discussion_r131513710
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/AbsoluteTableIdentifier.java ---
    @@ -99,8 +98,9 @@ public static AbsoluteTableIdentifier fromTablePath(String tablePath) {
       }
     
       public String getTablePath() {
    -    return getStorePath() + File.separator + getCarbonTableIdentifier().getDatabaseName() +
    -        File.separator + getCarbonTableIdentifier().getTableName();
    +    return getStorePath() + CarbonCommonConstants.FILE_SEPARATOR + getCarbonTableIdentifier()
    --- End diff --
    
    why need to change this? In another modification in this PR, you still use `File.separator` in `renameBadRecord`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---