carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From linqer <...@git.apache.org>
Subject [GitHub] carbondata pull request #1234: fix bug in Spi2CarbondataTypeMapper method, i...
Date Fri, 04 Aug 2017 10:35:56 GMT
GitHub user linqer opened a pull request:

    https://github.com/apache/carbondata/pull/1234

    fix bug in Spi2CarbondataTypeMapper method, it will cause exception like

    com.facebook.presto.spi.PrestoException: DECIMAL precision must be in range [1, 38]
             at com.facebook.presto.spi.type.DecimalType.validatePrecisionScale(DecimalType.java:94)
             at com.facebook.presto.spi.type.ShortDecimalType.<init>(ShortDecimalType.java:34)
             at com.facebook.presto.spi.type.DecimalType.createDecimalType(DecimalType.java:37)
             at org.apache.carbondata.presto.CarbondataRecordSetProvider.Spi2CarbondataTypeMapper(CarbondataRecordSetProvider.java:257)
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/linqer/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1234
    
----
commit 7ff11cbd2e9d22240cf8894da2ee2cf8ff4314e7
Author: linqer.li <linqer.li@vipshop.com>
Date:   2017-08-02T08:15:01Z

    fix bug in Spi2CarbondataTypeMapper method, it will cause exception like
    
    com.facebook.presto.spi.PrestoException: DECIMAL precision must be in range [1, 38]
             at com.facebook.presto.spi.type.DecimalType.validatePrecisionScale(DecimalType.java:94)
             at com.facebook.presto.spi.type.ShortDecimalType.<init>(ShortDecimalType.java:34)
             at com.facebook.presto.spi.type.DecimalType.createDecimalType(DecimalType.java:37)
             at org.apache.carbondata.presto.CarbondataRecordSetProvider.Spi2CarbondataTypeMapper(CarbondataRecordSetProvider.java:257)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message