carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1221: [CARBONDATA-1351]When 'SORT_SCOPE'='GLOBAL_SO...
Date Tue, 01 Aug 2017 08:43:52 GMT
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/1221

    [CARBONDATA-1351]When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.c…

    …olumnpage'='true', 'ThreadLocalTaskInfo.getCarbonTaskInfo()' return null
    
    When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.columnpage'='true', it uses native
RDD of Spark to load data, the method of 'ThreadLocalTaskInfo.setCarbonTaskInfo(carbonTaskInfo)'
in ‘CarbonRDD.compute’ does not be called, so 'ThreadLocalTaskInfo.getCarbonTaskInfo()'
will return null in some unsafe related classes, such as: UnsafeFixLengthColumnPage, UnsafeVarLengthColumnPage,
UnsafeMemoryDMStore and so on.
    
    Solution: Set the CarbonTaskInfo in the method of 'ThreadLocalTaskInfo.getCarbonTaskInfo()'
when 'threadLocal.get()' is null.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-1351

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1221
    
----
commit 211d392759d5dcfcff4046a111e15cb500c0acf9
Author: Zhang Zhichao <441586683@qq.com>
Date:   2017-08-01T08:42:16Z

    [CARBONDATA-1351]When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.columnpage'='true',
'ThreadLocalTaskInfo.getCarbonTaskInfo()' return null
    
    [CARBONDATA-1351]When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.columnpage'='true',
'ThreadLocalTaskInfo.getCarbonTaskInfo()' return null
    When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.columnpage'='true', it uses native
RDD of Spark to load data, the method of 'ThreadLocalTaskInfo.setCarbonTaskInfo(carbonTaskInfo)'
in ‘CarbonRDD.compute’ does not be called, so 'ThreadLocalTaskInfo.getCarbonTaskInfo()'
will return null in some unsafe related classes, such as: UnsafeFixLengthColumnPage, UnsafeVarLengthColumnPage,
UnsafeMemoryDMStore and so on.
    
    Solution: Set the CarbonTaskInfo in the method of 'ThreadLocalTaskInfo.getCarbonTaskInfo()'
when 'threadLocal.get()' is null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message