carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1297: [CARBONDATA-1429] Add a value based compressi...
Date Thu, 31 Aug 2017 07:10:07 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1297#discussion_r136260340
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java
---
    @@ -165,9 +165,28 @@ public double getDouble(int rowId) {
         return doubleData[rowId];
       }
     
    -  @Override
    -  public BigDecimal getDecimal(int rowId) {
    -    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  @Override public BigDecimal getDecimal(int rowId) {
    --- End diff --
    
    Please correct me If I am wrong....From my opinion it will not be any advantage to add
DecimalColumnPage as we are not doing anything extra if we introduce DecimalColumnPage.
    Basically we are storing values either as fixed or variable length and decimal values
also falls in these 2 categories. So according to current design I believe it may not be required
to introduce 1 more type of page until and unless we have pages for all other datatypes separately.
    Please share your suggestions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message