carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1304: [CARBONDATA-1411][CARBONDATA-1414] Show Segme...
Date Thu, 31 Aug 2017 04:25:10 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1304#discussion_r136243363
  
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
    @@ -258,92 +258,105 @@ public static void deleteLocalDataLoadFolderLocation(CarbonLoadModel
loadModel,
        * @throws IOException
        */
       public static boolean recordLoadMetadata(LoadMetadataDetails newMetaEntry,
    -      CarbonLoadModel loadModel, boolean loadStartEntry, boolean insertOverwrite)
    +      CarbonLoadModel loadModel, boolean loadStartEntry, boolean insertOverwrite, boolean
isUpdate)
    --- End diff --
    
    I think we may not require to change this code, In update case this method shouldn't be
called


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message