carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pawanmalwal <...@git.apache.org>
Subject [GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...
Date Thu, 24 Aug 2017 11:24:52 GMT
Github user pawanmalwal commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1281#discussion_r134990100
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java
---
    @@ -163,17 +163,17 @@ public FilterResolverIntf getFilterResolver(Expression expressionTree,
       }
     
       private String joinByteArray(byte[] bytes, char delimiter) {
    -    StringBuffer byteArrayAsString = new StringBuffer();
    -    byteArrayAsString.append("");
    +    String byteArrayAsString = "";
    --- End diff --
    
    Changed to StringBuffer per your suggestion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message