carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1248: [CARBONDATA-1371] Support creating decoder ba...
Date Tue, 22 Aug 2017 03:17:16 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1248#discussion_r134376519
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -68,8 +74,38 @@ public DataType getDataType() {
         return dataType;
       }
     
    -  public Object getStatistics() {
    -    return statsCollector.getPageStats();
    +  public SimpleStatsResult getStatistics() {
    +    if (statsCollector != null) {
    +      return statsCollector.getPageStats();
    +    } else {
    +      // return a dummy result, for complex column
    +      return new SimpleStatsResult() {
    --- End diff --
    
    Better create class separately and set to ColumnPage instead of creating class instance
every time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message