carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
Date Tue, 22 Aug 2017 03:13:09 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1276#discussion_r134376168
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
    @@ -369,6 +369,14 @@ object CommonUtil {
         }
       }
     
    +  def validateListInfo(listInfo: List[List[String]]): Unit = {
    --- End diff --
    
    two more things:
    1. this function is only used once, so I think there is no need to place it in `CommonUtil`.
    2. is `distinct` case-sensitive or not?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message