carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <>
Subject [GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Date Mon, 21 Aug 2017 12:28:31 GMT
Github user anubhav100 commented on a diff in the pull request:
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/processor/
    @@ -0,0 +1,239 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.presto.processor;
    +import java.util.List;
    +import java.util.concurrent.Callable;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Future;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +import org.apache.carbondata.common.CarbonIterator;
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +import org.apache.carbondata.core.datastore.DataRefNode;
    +import org.apache.carbondata.core.datastore.FileHolder;
    +import org.apache.carbondata.presto.scan.collector.ResultCollectorFactory;
    +import org.apache.carbondata.core.scan.collector.ScannedResultCollector;
    +import org.apache.carbondata.core.scan.executor.infos.BlockExecutionInfo;
    +import org.apache.carbondata.core.scan.processor.BlockletIterator;
    +import org.apache.carbondata.core.scan.processor.BlocksChunkHolder;
    +import org.apache.carbondata.core.scan.result.AbstractScannedResult;
    +import org.apache.carbondata.core.scan.result.vector.CarbonColumnarBatch;
    +import org.apache.carbondata.core.scan.scanner.BlockletScanner;
    +import org.apache.carbondata.core.scan.scanner.impl.FilterScanner;
    +import org.apache.carbondata.core.scan.scanner.impl.NonFilterScanner;
    +import org.apache.carbondata.core.stats.QueryStatisticsModel;
    + * This abstract class provides a skeletal implementation of the
    + * Block iterator.
    + */
    +public abstract class AbstractDataBlockIterator extends CarbonIterator<List<Object[]>>
    --- End diff --
    only extending the core abstractdatatblockiterator will not solve our problem,if i extend
it then it will pick up result collector from core module that is row based result collector
which was initilized in its constructor 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message