carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1267: [CARBONDATA-1326] Findbug fixes
Date Sat, 19 Aug 2017 04:48:16 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1267#discussion_r134082911
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonDeleteFilesDataReader.java
---
    @@ -216,6 +198,17 @@ public DeleteDeltaBlockDetails getCompactedDeleteDeltaFileFromBlock(List<String>
         }
         return deleteDeltaResultSet;
       }
    +  static class DeleteDeltaFileReaderCallable implements Callable<DeleteDeltaBlockDetails>
{
    --- End diff --
    
    Why use `static` class ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message