carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Date Fri, 18 Aug 2017 08:20:31 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1257#discussion_r133904450
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/AbstractAggregatedMemoryContext.java
---
    @@ -0,0 +1,40 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.presto.memory;
    +
    +
    +abstract class AbstractAggregatedMemoryContext
    +{
    +  // This class should remain exactly the same as AbstractAggregatedMemoryContext in
com.facebook.presto.memory
    +
    +  // AbstractMemoryContext class is only necessary because we need implementations that
bridge
    +  // AggregatedMemoryContext with the existing memory tracking APIs in XxxxContext. Once
they
    +  // are refactored, there will be only one implementation of this abstract class, and
this class
    +  // can be removed.
    +
    +  protected abstract void updateBytes(long bytes);
    +
    +  public AggregatedMemoryContext newAggregatedMemoryContext()
    +  {
    --- End diff --
    
    please correct the code format


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message