carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sraghunandan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1259: [Review][CARBONDATA-1381] Add test cases for ...
Date Fri, 18 Aug 2017 04:58:39 GMT
Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1259#discussion_r133879745
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/BucketingInfo.java
---
    @@ -44,4 +51,21 @@ public int getNumberOfBuckets() {
         return numberOfBuckets;
       }
     
    +  @Override public void write(DataOutput out) throws IOException {
    +    out.writeInt(numberOfBuckets);
    +    out.writeInt(listOfColumns.size());
    +    for (ColumnSchema aColSchema : listOfColumns) {
    +      aColSchema.write(out);
    +    }
    +  }
    +
    +  @Override public void readFields(DataInput in) throws IOException {
    +    this.numberOfBuckets = in.readInt();
    +    int colSchemaSize = in.readInt();
    +    listOfColumns = new ArrayList<>(colSchemaSize);
    +    for (int i = 0; i < colSchemaSize; i++) {
    +      ColumnSchema aSchema = new ColumnSchema();
    +      aSchema.readFields(in);
    --- End diff --
    
    good one, handled


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message