carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1248: [CARBONDATA-1371] Support creating decoder ba...
Date Thu, 17 Aug 2017 12:59:22 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1248#discussion_r133704869
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/dimension/legacy/IndexStorageEncoder.java
---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page.encoding.dimension.legacy;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastore.columnar.IndexStorage;
    +import org.apache.carbondata.core.datastore.page.ColumnPage;
    +import org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoder;
    +import org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoderMeta;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.format.DataChunk2;
    +import org.apache.carbondata.format.SortState;
    +
    +public abstract class IndexStorageEncoder extends ColumnPageEncoder {
    +  IndexStorage indexStorage;
    +  byte[] compressedDataPage;
    +
    +  abstract void encodeIndexStorage(ColumnPage inputPage);
    +
    +  @Override
    +  protected byte[] encodeData(ColumnPage input) throws MemoryException, IOException {
    +    assert (indexStorage == null);
    +    assert (compressedDataPage == null);
    +    encodeIndexStorage(input);
    +    assert (indexStorage != null);
    +    assert (compressedDataPage != null);
    +    ByteArrayOutputStream stream = new ByteArrayOutputStream();
    +    DataOutputStream out = new DataOutputStream(stream);
    +    out.write(compressedDataPage);
    +    if (indexStorage.getRowIdPageLengthInBytes() > 0) {
    +      out.writeInt(indexStorage.getRowIdPageLengthInBytes());
    +      short[] rowIdPage = (short[])indexStorage.getRowIdPage();
    +      for (short rowId : rowIdPage) {
    +        out.writeShort(rowId);
    +      }
    +      if (indexStorage.getRowIdRlePageLengthInBytes() > 0) {
    +        short[] rowIdRlePage = (short[])indexStorage.getRowIdRlePage();
    +        for (short rowIdRle : rowIdRlePage) {
    +          out.writeShort(rowIdRle);
    +        }
    +      }
    +    }
    +    if (indexStorage.getDataRlePageLengthInBytes() > 0) {
    +      short[] dataRlePage = (short[])indexStorage.getDataRlePage();
    +      for (short dataRle : dataRlePage) {
    +        out.writeShort(dataRle);
    +      }
    +    }
    +    return stream.toByteArray();
    +  }
    +
    +  @Override
    +  protected ColumnPageEncoderMeta getEncoderMeta(ColumnPage inputPage) {
    +    return null;
    --- End diff --
    
    I have not changed this behavior, this is the way currently writing dimension column.
    I will add new encoding for no dictionary string column in next PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message