carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1231: [CARBONDATA-1359] Unable to use carbondata on...
Date Thu, 17 Aug 2017 09:57:06 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1231#discussion_r133666819
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
    @@ -94,20 +94,21 @@ private static void populateCarbonTable(Configuration configuration,
String path
         } else {
           if (paths != null) {
             for (String inputPath : inputPaths) {
    -          if (paths.startsWith(inputPath)) {
    +          if (paths.startsWith(inputPath.replace("file:", ""))) {
                 validInputPath = inputPath;
                 break;
               }
             }
           }
         }
    -    AbsoluteTableIdentifier absoluteTableIdentifier =
    -        AbsoluteTableIdentifier.fromTablePath(validInputPath);
    -    // read the schema file to get the absoluteTableIdentifier having the correct table
id
    -    // persisted in the schema
    -    CarbonTable carbonTable = SchemaReader.readCarbonTableFromStore(absoluteTableIdentifier);
    -    setTableInfo(configuration, carbonTable.getTableInfo());
    -  }
    +      AbsoluteTableIdentifier absoluteTableIdentifier =
    +              AbsoluteTableIdentifier.fromTablePath(validInputPath);
    +      // read the schema file to get the absoluteTableIdentifier having the correct table
id
    --- End diff --
    
    This part code has some code style issue, please fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message