carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1259: [Review][CARBONDATA-1381] Add test cases for ...
Date Thu, 17 Aug 2017 09:17:10 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1259#discussion_r133662489
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
    @@ -129,4 +136,77 @@ public int getPartitionId(int index) {
         return partitionIds.get(index);
       }
     
    +  @Override public void write(DataOutput out) throws IOException {
    +    out.writeInt(columnSchemaList.size());
    +    for (ColumnSchema column : columnSchemaList) {
    +      column.write(out);
    +    }
    +    out.writeInt(partitionType.ordinal());
    +    if (PartitionType.RANGE.equals(partitionType)) {
    +      out.writeInt(rangeInfo.size());
    +      for (String aValue : rangeInfo) {
    +        out.writeUTF(aValue);
    +      }
    +    }
    +
    +    out.writeInt(partitionIds.size());
    +    for (Integer intVal : partitionIds) {
    +      out.writeInt(intVal);
    +    }
    +
    +    if (PartitionType.LIST.equals(partitionType)) {
    +      out.writeInt(listInfo.size());
    +      for (List<String> aList : listInfo) {
    +        out.writeInt(aList.size());
    +        for (String aInfo : aList) {
    +          out.writeUTF(aInfo);
    +        }
    +      }
    +    }
    +
    +    out.writeInt(numPartitions);
    +    out.writeInt(MAX_PARTITION);
    --- End diff --
    
    should change variable name of `MAX_PARTITION`, it is not constant


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message