carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <>
Subject [GitHub] carbondata pull request #1259: [Review][CARBONDATA-1381] Add test cases for ...
Date Thu, 17 Aug 2017 09:12:53 GMT
Github user jackylk commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/
    @@ -110,6 +108,7 @@
             return org.apache.carbondata.format.Encoding.BIT_PACKED;
           case DIRECT_DICTIONARY:
             return org.apache.carbondata.format.Encoding.DIRECT_DICTIONARY;
    +      case DICTIONARY:
             return org.apache.carbondata.format.Encoding.DICTIONARY;
    --- End diff --
    Actually I think here we should check it more strictly. If we do not recognize it, we
should throw exception.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message