carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Date Wed, 16 Aug 2017 07:37:16 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1257#discussion_r133377510
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java
---
    @@ -0,0 +1,103 @@
    +package org.apache.carbondata.presto.readers;
    +
    +import java.io.IOException;
    +import java.math.BigDecimal;
    +import java.math.BigInteger;
    +
    +import com.facebook.presto.spi.block.Block;
    +import com.facebook.presto.spi.block.BlockBuilder;
    +import com.facebook.presto.spi.block.BlockBuilderStatus;
    +import com.facebook.presto.spi.type.DecimalType;
    +import com.facebook.presto.spi.type.Decimals;
    +import com.facebook.presto.spi.type.Type;
    +import io.airlift.slice.Slice;
    +
    +import static com.facebook.presto.spi.type.Decimals.encodeUnscaledValue;
    +import static com.facebook.presto.spi.type.Decimals.isShortDecimal;
    +import static com.facebook.presto.spi.type.Decimals.rescale;
    +import static com.google.common.base.Preconditions.checkArgument;
    +import static com.google.common.base.Preconditions.checkState;
    +import static io.airlift.slice.Slices.utf8Slice;
    +import static java.math.RoundingMode.HALF_UP;
    +
    +public class DecimalSliceStreamReader implements StreamReader {
    --- End diff --
    
    This pr is optimizing for column reader, why need to add StreamReader ?  please consider
using different PR to implement different features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message