carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Date Wed, 16 Aug 2017 07:02:27 GMT
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1257#discussion_r133371582
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java
---
    @@ -183,7 +183,7 @@ public String getString() throws FilterIllegalMemberException {
                 return parser.format((java.sql.Date) value);
               } else if (value instanceof Long) {
                 if (isLiteral) {
    -              return parser.format(new Timestamp((long) value / 1000));
    +              return parser.format(new Timestamp((long) value));
    --- End diff --
    
    @chenliang613 earlier time stamp was getting multiplied by 1000 in carbondata so thats
why it was wriiten as 
    -return parser.format(new Timestamp((long) value / 1000));
    but now it is not getting multipled by 1000 so at time of building expression result so
now there is no need of dividing timestamp by 1000



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message