carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1239: [CARBONDATA-1343] Hive can't query data when ...
Date Fri, 11 Aug 2017 13:31:10 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1239#discussion_r132685377
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
    @@ -84,47 +92,66 @@
        * @param configuration
        * @throws IOException
        */
    -  private static void populateCarbonTable(Configuration configuration, String paths)
    +  private CarbonTable populateCarbonTable(Configuration configuration)
           throws IOException {
    -    String dirs = configuration.get(INPUT_DIR, "");
    -    String[] inputPaths = StringUtils.split(dirs);
    -    String validInputPath = null;
    +    TableInfo tableInfo = getTableInfo(configuration);
    +    CarbonTable carbonTable = null;
    +    if (tableInfo != null) {
    +      carbonTable = CarbonTable.buildFromTableInfo(tableInfo);
    +      CarbonMetadata.getInstance().addCarbonTable(carbonTable);
    +      return carbonTable;
    +    }
    +    String inputDir = configuration.get(INPUT_DIR, "");
    +    String[] inputPaths = StringUtils.split(inputDir);
         if (inputPaths.length == 0) {
           throw new InvalidPathException("No input paths specified in job");
    -    } else {
    -      if (paths != null) {
    -        for (String inputPath : inputPaths) {
    -          if (paths.startsWith(inputPath)) {
    -            validInputPath = inputPath;
    -            break;
    -          }
    -        }
    -      }
         }
    +    Arrays.sort(inputPaths);
    +    String tablePath = inputPaths[0].replace("file:", "");
    --- End diff --
    
    Is this a mistake?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message