carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1245: [CARBONDATA-1366]add an option 'carbon.global...
Date Thu, 10 Aug 2017 05:11:49 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1245#discussion_r132364955
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -1304,6 +1304,18 @@
        */
       public static final String CARBON_USE_MULTI_TEMP_DIR_DEFAULT = "false";
     
    +  /**
    +   * Which storage level to persist rdd when sort_scope=global_sort
    +   */
    +  @CarbonProperty
    +  public static final String CARBON_GLOBAL_SORT_RDD_STORAGE_LEVEL =
    +      "carbon.global.sort.rdd.storage.level";
    +
    +  /**
    +   * default value for carbon.global.sort.rdd.storage.level
    --- End diff --
    
    In the comment, mention that the default value is designed for machine with big memory,
if user environment has less memory, set the  `CARBON_GLOBAL_SORT_RDD_STORAGE_LEVEL` according
to `MEMORY_AND_DISK` (see spark recommendation) and give a URL in the comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message