carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1245: [CARBONDATA-1366]add an option 'carbon.global...
Date Thu, 10 Aug 2017 05:09:32 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1245#discussion_r132364666
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -1714,6 +1714,45 @@ public static boolean isValidSortOption(String sortScope) {
       }
     
       /**
    +   * validate the storage level
    +   * @param storageLevel
    +   * @return boolean
    +   */
    +  public static boolean isValidStorageLevel(String storageLevel) {
    +    if (null == storageLevel || storageLevel.trim().equals("")) {
    +      return false;
    +    }
    +    switch (storageLevel.toUpperCase()) {
    +      case "DISK_ONLY":
    +        return true;
    --- End diff --
    
    I think for all cases you can keep one `return true` is enough


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message