carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...
Date Mon, 07 Aug 2017 11:50:49 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1192#discussion_r131635037
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
    @@ -181,9 +181,11 @@ public static void createLocations(String[] locations) {
        * @return
        */
       public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
    --- End diff --
    
    refactor it, make it two functions, should not add more boolean to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message