carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1238: [CARBONDATA-1363] Add DataMapWriter interface
Date Mon, 07 Aug 2017 09:13:39 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1238#discussion_r131607244
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapMeta.java ---
    @@ -14,37 +14,25 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.carbondata.core.indexstore;
     
    -import java.io.DataOutput;
    +package org.apache.carbondata.core.datamap;
     
    -/**
    - * Data Map writer
    - */
    -public interface DataMapWriter<T> {
    +public class DataMapMeta {
     
    -  /**
    -   * Initialize the data map writer with output stream
    -   *
    -   * @param outStream
    -   */
    -  void init(DataOutput outStream);
    +  public DataMapMeta(String indexedColumn, OperationType optimizedOperation) {
    --- End diff --
    
    I prefer to keep it simple in this PR. We can do it later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message