carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1242: [WIP]Offheap sort size validation
Date Mon, 07 Aug 2017 05:49:05 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1242#discussion_r131576451
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/hive/DistributionUtil.scala
---
    @@ -115,7 +115,9 @@ object DistributionUtil {
           sparkContext: SparkContext): Seq[String] = {
         val confExecutors: Int = getConfiguredExecutors(sparkContext)
         LOGGER.info(s"Executors configured : $confExecutors")
    -    val requiredExecutors = if (nodesOfData < 1 || nodesOfData > confExecutors)
{
    +    val requiredExecutors = if (nodesOfData < 1) {
    +      1
    +    } else if (nodesOfData > confExecutors) {
    --- End diff --
    
    this change duplicates [PR-1241](https://github.com/apache/carbondata/pull/1241)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message