carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1237: Clean up CarbonFactDataHandlerColumnar
Date Fri, 04 Aug 2017 18:56:37 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1237#discussion_r131462351
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
    @@ -644,10 +556,9 @@ private void resetBlockletProcessingCount() {
       }
     
       /**
    -   * This class will hold the holder objects and manage producer and consumer for reading
    -   * and writing the blocklet data
    +   * This class will hold the encoded table pages.
        */
    -  private final class BlockletDataHolder {
    +  private final class TablePageList {
    --- End diff --
    
    This class only holds some table pages, size of which equals to number of cores, but not
blocklet. So rename it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message