carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...
Date Fri, 04 Aug 2017 05:30:11 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1227#discussion_r131314408
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/InsertIntoCarbonTableTestCase.scala
---
    @@ -252,13 +231,12 @@ class InsertIntoCarbonTableTestCase extends QueryTest with BeforeAndAfterAll
{
         sql("insert overwrite table CarbonOverwrite select * from THive")
         sql("insert overwrite table HiveOverwrite select * from THive")
         checkAnswer(sql("select count(*) from CarbonOverwrite"), sql("select count(*) from
HiveOverwrite"))
    -    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
timeStampPropOrig)
    +    val folder = new File(s"$storeLocation/default/CarbonOverwrite/Fact/Part0/")
    --- End diff --
    
    CarbonOverwrite is always writes in lower case as folder, so use as below to avoid test
failure, 
    ```
    val folder = new File(s"$storeLocation/default/carbonoverwrite/Fact/Part0/")
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message