carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1228: [CARBONDATA-1357] fix convert bug
Date Fri, 04 Aug 2017 03:55:01 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1228#discussion_r131307316
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeConverterImpl.java
---
    @@ -29,7 +31,7 @@ public Object convertToDecimal(Object data) {
       }
     
       public Object convertFromByteToUTF8String(Object data) {
    -    return data.toString();
    +    return new String((byte[]) data, CarbonCommonConstants.DEFAULT_CHARSET_CLASS);
    --- End diff --
    
    There is a java style error, try to remove the blank before 'data'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message