carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1227: [CARBONDATA-1356] Delete stale folder in inse...
Date Thu, 03 Aug 2017 14:16:36 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1227#discussion_r131154027
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
    @@ -87,6 +87,10 @@ else if (path.startsWith(CarbonCommonConstants.VIEWFSURL_PREFIX)) {
         return FileType.LOCAL;
       }
     
    +  public static CarbonFile getCarbonFile(String path) {
    --- End diff --
    
    I don't think it is better to change the existing caller methods, going forward user can
use this if he needs it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message