carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1217: [CARBONDATA-1345] Update tablemeta cache afte...
Date Wed, 02 Aug 2017 01:55:47 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1217#discussion_r130770423
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonSessionState.scala
---
    @@ -81,34 +81,38 @@ class CarbonSessionCatalog(
       override def lookupRelation(name: TableIdentifier,
           alias: Option[String]): LogicalPlan = {
         val rtnRelation = super.lookupRelation(name, alias)
    -    rtnRelation match {
    -      case SubqueryAlias(_,
    -          LogicalRelation(carbonDatasourceHadoopRelation: CarbonDatasourceHadoopRelation,
_, _),
    -          _) =>
    -        refreshRelationFromCache(name, alias, carbonDatasourceHadoopRelation)
    +    var toRefreshRelation = false
    +    rtnRelation foreach {
    --- End diff --
    
    Better add `SubqueryAlias(_, LogicalRelation(carbonDatasourceHadoopRelation: CarbonDatasourceHadoopRelation,
_, _)` condition as well. There might be some scenarios it may come, so better add this as
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message