carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...
Date Tue, 01 Aug 2017 01:49:55 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1192#discussion_r130503124
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -440,9 +510,17 @@ protected Expression getFilterPredicates(Configuration configuration)
{
             for (Map.Entry<SegmentTaskIndexStore.TaskBucketHolder, AbstractIndex> entry
:
                 segmentIndexMap.entrySet()) {
               SegmentTaskIndexStore.TaskBucketHolder taskHolder = entry.getKey();
    -          int taskId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    +          int partitionId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    --- End diff --
    
    **partitionId**...get**TaskId**FromTaskNo?
    
    Is this OK?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message