carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...
Date Tue, 01 Aug 2017 01:49:51 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1192#discussion_r130501212
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
    @@ -65,6 +65,31 @@ public PartitionInfo(List<ColumnSchema> columnSchemaList, PartitionType
partitio
         this.partitionIds = new ArrayList<>();
       }
     
    +  /**
    +   * add partition means split default partition, add in last directly
    +   */
    +  public void  addPartition(int addPartitionCount) {
    +    for (int i = 0; i < addPartitionCount; i++) {
    +      partitionIds.add(++MAX_PARTITION);
    +      numPartitions++;
    +    }
    +  }
    +
    +  /**
    +   * e.g. original partition[0,1,2,3,4,5]
    +   * split partition 2 to partition 6,7,8 (will not reuse 2)
    +   * then sourcePartitionId is 2, newPartitionNumbers is 3
    +   * @param sourcePartitionIndex
    +   * @param newPartitionNumbers
    +   */
    +  public void splitPartition(int sourcePartitionIndex, int newPartitionNumbers) {
    --- End diff --
    
    When will partition-split action be triggered?
    
    In my memory, there is no “partition-split” action in Hive, etc. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message