Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenliang613 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1134-carbondata@git.apache.org>
In-Reply-To: <git-pr-1134-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1134: [CARBONDATA-1262] Remove unnecessary LoadConf...
Content-Type: text/plain
Message-Id: <20170727152623.BAEB2E360F@git1-us-west.apache.org>
Date: Thu, 27 Jul 2017 15:26:23 +0000 (UTC)
archived-at: Thu, 27 Jul 2017 15:26:25 -0000

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1134#discussion_r129874324
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -465,6 +463,29 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
       }
     
       /**
    +   * Return the sort scope enum.
    +   */
    +  public static SortScopeOptions.SortScope getSortScope(String sortScopeString) {
    +    SortScopeOptions.SortScope sortScope;
    +    try {
    +      // first check whether user input it from ddl, otherwise get from carbon properties
    --- End diff --
    
    suggest changing "it" to "sort scope"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---