Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenerlu <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1192-carbondata@git.apache.org>
In-Reply-To: <git-pr-1192-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...
Content-Type: text/plain
Message-Id: <20170726150306.100DEDFB94@git1-us-west.apache.org>
Date: Wed, 26 Jul 2017 15:03:06 +0000 (UTC)
archived-at: Wed, 26 Jul 2017 15:03:07 -0000

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1192#discussion_r129598686
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -440,9 +510,16 @@ protected Expression getFilterPredicates(Configuration configuration) {
             for (Map.Entry<SegmentTaskIndexStore.TaskBucketHolder, AbstractIndex> entry :
                 segmentIndexMap.entrySet()) {
               SegmentTaskIndexStore.TaskBucketHolder taskHolder = entry.getKey();
    -          int taskId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    +          int partitionId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    +          //oldPartitionIdList is only used in alter table partition command because it change
    +          //partition info first and then read data.
    +          //for other normal query should use newest partitionIdList
    --- End diff --
    
    use /** */ instead if multi line notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---