Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1191-carbondata@git.apache.org>
In-Reply-To: <git-pr-1191-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1191: [CARBONDATA-1326] Fixed high priority findbug...
Content-Type: text/plain
Message-Id: <20170722063224.D8B7BDFC34@git1-us-west.apache.org>
Date: Sat, 22 Jul 2017 06:32:24 +0000 (UTC)
archived-at: Sat, 22 Jul 2017 06:32:27 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1191#discussion_r128890954
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/mutate/DeleteDeltaBlockletDetails.java ---
    @@ -69,9 +69,11 @@ public Integer getPageId() {
         if (obj == null || !(obj instanceof DeleteDeltaBlockletDetails)) {
           return false;
         }
    -
         DeleteDeltaBlockletDetails that = (DeleteDeltaBlockletDetails) obj;
    -    return id.equals(that.id) && pageId == that.pageId;
    +    if (null == pageId || null == that.pageId) {
    +      return false;
    +    }
    +    return id.equals(that.id) && pageId.intValue() == that.pageId.intValue();
    --- End diff --
    
    change to `return id.equals(that.id) && (pageId.intValue() == that.pageId.intValue());`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---